[Lldb-commits] [PATCH] Add Debugger::InitializeForLLGS to allow ref counted LLGS initialization.

[Robert Flack]

Hi vharron, tberghammer, clayborg,

After http://reviews.llvm.org/D8133 landed as r231550 process launch on remote platform stopped working.

This adds Debugger::InitializeForLLGS and tracks whether one or both of Initialize and InitializeForLLGS have been called, calling only the corresponding lldb_private::Terminate* methods as necessary. Since lldb_private::Terminate calls lldb_private::TerminateForLLGS, the latter method may be called twice if Initialize was called for both however the terminate methods ensure they are only called once after being initialized.

This still maintains the reduced binary size, though it does now technically link in lldb_private::Terminate on lldb-server even though this should never be called.

This should resolve the issue raised in http://reviews.llvm.org/D8133 where Debugger::Terminate assumed that there were 0 references to debugger and terminated early.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8183

Files:
  include/lldb/Core/Debugger.h
  source/Core/Debugger.cpp
  source/lldb.cpp
  tools/lldb-server/lldb-server.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8183.21514.patch
Type: text/x-patch
Size: 9373 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150309/e8eb24d8/attachment.bin>