[Lldb-commits] [PATCH] Add Utility/ModuleCache class and integrate it with PlatformGDBRemoteServer - in order to allow modules caching from remote targets.

[Greg Clayton]

Inlined comments that didn't get submitted...


================
Comment at: include/lldb/Core/ModuleSpec.h:17
@@ -16,2 +16,3 @@
 #include "lldb/Host/FileSpec.h"
+#include "lldb/Host/Mutex.h"
 #include "lldb/Target/PathMappingList.h"
----------------
Does this need to be in the header file?

================
Comment at: source/Core/Debugger.cpp:700-703
@@ -699,2 +699,6 @@
                                      Target::GetGlobalProperties()->GetValueProperties());
+    m_collection_sp->AppendProperty (ConstString("platform"),
+                                     ConstString("Platform settings."),
+                                     true,
+                                     Platform::GetGlobalPlatformProperties()->GetValueProperties());
     if (m_command_interpreter_ap.get())
----------------
Does this play well with the other "platform" settings that are already there?

platform.plugin.linux.use-llgs-for-local (boolean) = false
platform.plugin.darwin-kernel.search-locally-for-kexts (boolean) = true
platform.plugin.darwin-kernel.kext-directories (file-list) =

http://reviews.llvm.org/D8037

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/