[Lldb-commits] [PATCH] Can't set watchpoints on launching threads on Linux LLGS.

[Oleksiy Vyalov]

In http://reviews.llvm.org/D7914#135273, @chaoren wrote:

> > Yes, it's safe to send PTRACE request to a thread when it in stopped
>
>
> state.
>
> But is it *only* the stopped state? It shouldn't be possible to set a
>  watchpoint in any other state right?


Yes - I think so.

> 

> 

> > How do you reproduce this situation with setting watchpoint on a running

> 

> 

> thread?

> 

> TestSetWatchlocation and TestTargetWatchAddress both occasionally fail due

>  to this. It manifests as failing to set watchpoint. The threads should have

>  been stopped, but they're still eStateRunning when the process tried to set

>  watchpoints.


It will be interesting to see gdb-remote logs for these tests - to check whether llgs got vCont continue request first and then received Z request for watchpoint.. Or maybe lldb thinks that all threads are stopped in inferior but llgs is messing with some threads' states.


http://reviews.llvm.org/D7914

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/