[Lldb-commits] [PATCH] Change lldb_assert() to use llvm::sys::PrintBacktrace

Chandler Carruth chandlerc at gmail.com
Wed Mar 4 18:27:33 PST 2015

On Wed, Mar 4, 2015 at 6:06 PM Ed Maste <emaste at freebsd.org> wrote:

> On 4 March 2015 at 20:48, Enrico Granata <egranata at apple.com> wrote:
> >
> > In this case we could get away with the lesser interface (FILE*), that’s
> > true. However, if - say - we ended up deciding that the output of
> > lldbassert() should go to the user’s terminal AND to a log file, this
> would
> > be trivial to do with a StreamTee, but it would require more fiddling
> with a
> > FILE*
> The same argument can be made for adding that functionality in the
> LLVM implementation, I think. If there's value of having the output go
> to multiple sources, for example, other LLVM projects could also
> benefit from it.

Absolutely, 100%, yes.

I think it is tremendously important for LLDB, LLD, and every other
subproject to reuse core infrastructure like this wherever possible. That
is *not* because I believe that the core infrastructure is perfect! It is
because we need to collect all of the improvements each project needs and
share both the implementation cost and the benefits that they bring across
the projects. That is really key to making the entire project as a whole
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150305/eddbcb47/attachment.html>

More information about the lldb-commits mailing list