[Lldb-commits] [PATCH] Create NativeRegisterContext for android-arm64

Tamas Berghammer tberghammer at google.com
Wed Mar 4 12:58:26 PST 2015

In http://reviews.llvm.org/D8058#134459, @chaoren wrote:

> It would be nice if you showed the diff of the new files from the originals. I.e., git diff -U999999 -C -C

The similarity index for the files are so low (22% maximum) it wouldn't make any sense. This is caused by the very different code structure used by the RegisterContext* classes and the NativeRegisterContext* classes.

P.S.: I noticed that some part of the code is based on the RegisterContextPOSIXProcessMonitor_arm64 class.

Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:109
@@ +108,3 @@
+namespace {
+    // Number of register sets provided by this context.
vharron wrote:
> Just curious, why not static const int?
It  came from RegisterContextPOSIX_armm64, and I haven't changed it.

Comment at: source/Plugins/Process/Linux/ProcessMonitor.cpp:51
@@ -53,1 +50,3 @@
+#ifndef __ANDROID__
+#include <sys/procfs.h>
vharron wrote:
> duplicate block of defines should be moved into common header?
Will fix it tomorrow.
Do you have any suggestion for the name and location of the file (AndroidProcfs_arm64)?



More information about the lldb-commits mailing list