[Lldb-commits] [PATCH] Python split [1/2] - File renames
clayborg at gmail.com
Wed Mar 4 11:00:46 PST 2015
It seems like "lldb/Interpreter/ScriptInterpreter.h" still exists in your tree and you are able to compile because it is still there? It isn't there for me and there are 20 locations that are still trying to include it.
After fixing 100 or so build errors I am giving up on this patch. Please try to make it work for MacOSX. The major issues are:
- There is no need to create a new "include/lldb/ScriptInterpreter" directory it will just make merges very hard for us and it gains us nothing since only abstract virtual classes should be in there (and a default implementation for None)
- Where ever there is a #ifndef LLDB_DISABLE_PYTHON, this will need to be abstracted to go through the abstract ScriptInterpreter class for the current language.
- No one should be including ScriptInterpreterPython.h anywhere, they should just use the current ScriptInterpreter subclass gotten from the interpreter and anything that was being done using a special version of this class should be abstracted through ScriptInterpreter
- cases like ProcessGDBRemote::ParsePythonTargetDefinition(const FileSpec &target_definition_fspec) should find the script interpreter for the target definition file and call through the abstract ScriptInterpreter class to parse it somehow
More information about the lldb-commits