[Lldb-commits] [PATCH] Rename test/tools/lldb-gdbserver to test/tools/lldb-server

[Oleksiy Vyalov]

Please see my comments.


REPOSITORY
  rL LLVM

================
Comment at: test/tools/lldb-mi/signal/TestMiSignal.py:91
@@ -90,3 +90,3 @@
         # Prepare debugserver
-        sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "lldb-gdbserver")))
+        sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "lldb-server")))
         import lldbgdbserverutils
----------------
Please define a constant in this test for "lldb-server"

================
Comment at: test/tools/lldb-server/TestLldbGdbServer.py:4
@@ +3,3 @@
+
+Tests run against debugserver and lldb-gdbserver (llgs).
+lldb-gdbserver tests run where the lldb-gdbserver exe is
----------------
s/lldb-gdbserver/lldb-server

================
Comment at: test/tools/lldb-server/TestLldbGdbServer.py:55
@@ +54,3 @@
+        self.test_sequence.add_log_lines(
+            ["lldb-gdbserver <  26> read packet: $QThreadSuffixSupported#e4",
+             "lldb-gdbserver <   6> send packet: $OK#9a"],
----------------
lldb-server ?

================
Comment at: test/tools/lldb-server/TestLldbGdbServer.py:77
@@ +76,3 @@
+        self.test_sequence.add_log_lines(
+            ["lldb-gdbserver <  27> read packet: $QListThreadsInStopReply#21",
+             "lldb-gdbserver <   6> send packet: $OK#9a"],
----------------
ditto.

================
Comment at: test/tools/lldb-server/commandline/TestStubSetSID.py:32
@@ +31,3 @@
+        self.assertTrue(server.isalive())
+        server.expect("(debugserver|lldb-gdbserver)", timeout=10)
+
----------------
lldb-server?

================
Comment at: test/tools/lldb-server/gdbremote_testcase.py:207
@@ +206,3 @@
+        self.assertIsNotNone(server)
+        server.expect(r"(debugserver|lldb-gdbserver)", timeout=10)
+
----------------
s/lldb-gdbserver/lldb-server

================
Comment at: test/tools/lldb-server/lldbgdbserverutils.py:89
@@ +88,3 @@
+
+_LOG_LINE_REGEX = re.compile(r'^(lldb-gdbserver|debugserver)\s+<\s*(\d+)>' +
+    '\s+(read|send)\s+packet:\s+(.+)$')
----------------
s/lldb-gdb-server/lldb-server

http://reviews.llvm.org/D8061

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/