[Lldb-commits] [PATCH] Create NativeRegisterContext for android-arm64

Vince Harron vharron at google.com
Wed Mar 4 09:00:14 PST 2015


Adding Ed as reviewer


================
Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:109
@@ +108,3 @@
+
+namespace {
+    // Number of register sets provided by this context.
----------------
Just curious, why not static const int?


================
Comment at: source/Plugins/Process/Linux/ProcessMonitor.cpp:51
@@ -53,1 +50,3 @@
 
+#ifndef __ANDROID__
+#include <sys/procfs.h>
----------------
duplicate block of defines should be moved into common header?

http://reviews.llvm.org/D8058

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list