[Lldb-commits] [lldb] r231229 - Use the unified section list when generating a symbol table

Pavel Labath labath at google.com
Wed Mar 4 02:28:15 PST 2015

Author: labath
Date: Wed Mar  4 04:28:15 2015
New Revision: 231229

URL: http://llvm.org/viewvc/llvm-project?rev=231229&view=rev
Use the unified section list when generating a symbol table

Symbol table generation code was failing to take into account the debug symbols because
the object file was looking only into its own section list when doing the generation, even though
the debug symbols from another object file were correctly detected and loaded by the
SymbolVendor. This changes the code to use the unified section list, which fixes this problem.

Test Plan:
I do not intend do submit this yet since it causes (or more like, exposes) the issue
in D7884, but I wanted to put this out here, so that anyone who wants to take a look at it can do
so. (And I also wanted to know if this is the right approach to the problem :).

Reviewers: clayborg, zturner

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D7913


Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp?rev=231229&r1=231228&r2=231229&view=diff
--- lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Wed Mar  4 04:28:15 2015
@@ -2364,7 +2364,7 @@ ObjectFileELF::GetSymtab()
     if (m_symtab_ap.get() == NULL)
-        SectionList *section_list = GetSectionList();
+        SectionList *section_list = module_sp->GetSectionList();
         if (!section_list)
             return NULL;

More information about the lldb-commits mailing list