[Lldb-commits] [PATCH] Fix deadlock in operation thread in NativeProcessLinux
Oleksiy Vyalov
ovyalov at google.com
Tue Mar 3 09:41:08 PST 2015
Looks good - please see my comments.
================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3400
@@ -3401,1 +3399,3 @@
+ // will exit without posting to the semaphore
+ if (m_operation != EXIT_OPERATION)
{
----------------
You may have early return if m_operation == EXIT_OPERATION
================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3563
@@ -3558,3 +3562,3 @@
{
m_monitor_thread.Cancel();
m_monitor_thread.Join(nullptr);
----------------
Monitoring thread uses Cancel as well - should we redesign it for Android?
http://reviews.llvm.org/D8030
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list