[Lldb-commits] [PATCH] Fix expectation for TestPlatformCommand.test_shell

Vince Harron vharron at google.com
Tue Mar 3 07:54:30 PST 2015


================
Comment at: test/functionalities/platform/TestPlatformCommand.py:37
@@ -37,1 +36,3 @@
+        platform_name = self.dbg.GetSelectedPlatform().GetName()
+        if platform_name == "remote-windows" or (platform_name == "host" and sys.platform.startswith("win32")):
           self.expect("platform shell dir c:\\", substrs = ["Windows", "Program Files"])
----------------
I think that you should refactored into a function, maybe based off of compiler's target triple?

vharron-macbookpro:test vharron$ clang -target x86_64--linux-gnu --version
Apple LLVM version 6.0 (clang-600.0.56) (based on LLVM 3.5svn)
Target: x86_64--linux-gnu
Thread model: posix

vharron at tifa:~/ll/svn/lldb/test$ gcc -m32 -print-multiarch
i386-linux-gnu

http://reviews.llvm.org/D8031

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list