[Lldb-commits] [PATCH] Applying D7950 to four near copies of the file.

[Chaoren Lin]

================
Comment at: test/functionalities/stop-hook/multiple_threads/main.cpp:40
@@ -43,3 +39,3 @@
 {
-    uint32_t thread_index = *((uint32_t *)arg); // Break here to test that the stop-hook mechanism works for multiple threads.
+    // Break here to test that the stop-hook mechanism works for multiple threads.
     printf ("%s (thread index = %u) startng...\n", __FUNCTION__, thread_index);
----------------
vharron wrote:
> The test sets a breakpoint on this line.  That seems not great because there is executable code on this line.
> 
> lldb/test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py:39
> 
> I think you should move the comment to the printf, but if it works it's up to you.
I initially did move it to the printf, but the length of the line bothered me.
It should be identical anyway if breakpoints are behaving correctly. ¯\_(ツ)_/¯

http://reviews.llvm.org/D7991

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/