[Lldb-commits] [PATCH] Applying D7950 to four near copies of the file.
Vince Harron
vharron at google.com
Sun Mar 1 22:50:11 PST 2015
https://www.youtube.com/watch?v=z1DzZ7oShl4
================
Comment at: test/functionalities/stop-hook/multiple_threads/main.cpp:40
@@ -43,3 +39,3 @@
{
- uint32_t thread_index = *((uint32_t *)arg); // Break here to test that the stop-hook mechanism works for multiple threads.
+ // Break here to test that the stop-hook mechanism works for multiple threads.
printf ("%s (thread index = %u) startng...\n", __FUNCTION__, thread_index);
----------------
The test sets a breakpoint on this line. That seems not great because there is executable code on this line.
lldb/test/functionalities/stop-hook/multiple_threads/TestStopHookMultipleThreads.py:39
I think you should move the comment to the printf, but if it works it's up to you.
================
Comment at: test/functionalities/watchpoint/multiple_threads/main.cpp:44
@@ -45,3 +43,3 @@
{
- uint32_t thread_index = *((uint32_t *)arg); // Break here in order to allow the thread
- // to inherit the global watchpoint state.
+ // Break here in order to allow the thread
+ // to inherit the global watchpoint state.
----------------
Same here
================
Comment at: test/functionalities/watchpoint/multiple_threads/main.cpp:53
@@ -54,3 +52,3 @@
// random micro second sleep from zero to 3 seconds
- int usec = ::rand() % 3000000;
+ int usec = g_distribution(g_random_engine);
printf ("%s (thread = %u) doing a usleep (%d)...\n", __FUNCTION__, thread_index, usec);
----------------
Good you replaced this. rand only goes from 0-32767 on Windows.
http://reviews.llvm.org/D7991
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list