[Lldb-commits] [PATCH] Make print_cwd buildable on Windows

Zachary Turner zturner at google.com
Fri Feb 27 14:42:21 PST 2015


================
Comment at: test/functionalities/process_launch/print_cwd.cpp:3
@@ +2,3 @@
+
+#ifdef _WIN32
+#define _CRT_NONSTDC_NO_WARNINGS
----------------
I think this should be _MSC_VER.  mingw toolchains will still have <unistd.h> and getcwd.  We compile all our tests with clang, which does define _MSC_VER when in MSABI compat mode.  lgtm otherwise, I'll commit later.

http://reviews.llvm.org/D7962

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list