[Lldb-commits] [PATCH] Python split [1/2] - File renames

[Greg Clayton]

A little more clarification: it would be great if we can make the script interpreters link agains only the public API. So this is another vote for moving the script interpreter stuff down into "lldb/source/API/ScriptInterpreter".

Right now we have the restriction that The lldb::SB classes can only by code that is in the lldb/API folder. For that reason we have these callbacks in ScriptIntpreterPython that start with "LLDBSwigPython" and they currently can't use the lldb::SB classes because of where the ScriptInterpreterPython.cpp file is currently located: "lldb/source/Interpreter". So if we move the ScriptInterpreterPython.cpp into "source/API" we can move these callbacks to actually use the lldb::SB classes so this function:

  extern "C" bool LLDBSwigPythonBreakpointCallbackFunction(const char *python_function_name, const char *session_dictionary_name,
                                                           const lldb::StackFrameSP &sb_frame, const lldb::BreakpointLocationSP &sb_bp_loc);

Would become:

  bool LLDBSwigPythonBreakpointCallbackFunction(const char *python_function_name, const char *session_dictionary_name, const lldb::SBFrame &sb_frame, const lldb::SBBreakpointLocation &sb_bp_loc);

Then we can actually build the script interpreters as actual bonified plug-ins that are loaded by LLDB when it starts up since they will only link against the public API.


http://reviews.llvm.org/D7956

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/