[Lldb-commits] [lldb] r230782 - Skip LaunchInTerminalTestCase test on remote systems

Ilia K ki.stfu at gmail.com
Fri Feb 27 11:14:13 PST 2015


Author: ki.stfu
Date: Fri Feb 27 13:14:12 2015
New Revision: 230782

URL: http://llvm.org/viewvc/llvm-project?rev=230782&view=rev
Log:
Skip LaunchInTerminalTestCase test on remote systems

Summary:
This ability was added by @jasonmolenda in [[ http://reviews.llvm.org/rL225748 | r225748 ]] but it was commented out because he hadn't test it.
I tested it on OS X and now we can enable it legally.

This change is made by @chying request.

Reviewers: jasonmolenda, chying, clayborg

Reviewed By: clayborg

Subscribers: lldb-commits, chying, jasonmolenda, clayborg

Differential Revision: http://reviews.llvm.org/D7930

Modified:
    lldb/trunk/test/functionalities/tty/TestTerminal.py

Modified: lldb/trunk/test/functionalities/tty/TestTerminal.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/tty/TestTerminal.py?rev=230782&r1=230781&r2=230782&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/tty/TestTerminal.py (original)
+++ lldb/trunk/test/functionalities/tty/TestTerminal.py Fri Feb 27 13:14:12 2015
@@ -22,9 +22,9 @@ class LaunchInTerminalTestCase(TestBase)
     # privilege so it can't open the socket to talk back to the test case
     @unittest2.skipUnless(os.geteuid() != 0, "test cannot be run as root")
 
-    # Do we need to disable this test if the testsuite is being run on a rmeote system?
+    # Do we need to disable this test if the testsuite is being run on a remote system?
     # This env var is only defined when the shell is running in a local mac terminal window
-    # @unittest2.skipUnless(os.environ.has_key('TERM_PROGRAM'), "test must be run on local system")
+    @unittest2.skipUnless(os.environ.has_key('TERM_PROGRAM'), "test must be run on local system")
 
     def test_launch_in_terminal (self):
         exe = "/bin/ls"





More information about the lldb-commits mailing list