[Lldb-commits] [PATCH] Make it possible to stop the operation thread in NativeProcessLinux
Oleksiy Vyalov
ovyalov at google.com
Fri Feb 27 11:10:37 PST 2015
Looks good - please address suggestions before submitting.
================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3566
@@ -3557,3 +3565,3 @@
StopMonitoringChildProcess();
StopOpThread();
StopCoordinatorThread ();
----------------
Could you also swap StopOpThread() and StopCoordinatorThread ()?
If there there are en-queued and/or active commands in TSC thread that need PTRACE they will deadlock on DoOperation since operation thread has been stopped.
http://reviews.llvm.org/D7937
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list