[Lldb-commits] [PATCH] Skip LaunchInTerminalTestCase test on remote systems

[Ilia K]

Hi clayborg, jasonmolenda, chying,

This ability was added by @jasonmolenda in [[ http://reviews.llvm.org/rL225748 | r225748 ]] but it was commented out because he hadn't test it.
I tested it on OS X and now we can enable it legally.

This change is made by @chying request.

http://reviews.llvm.org/D7930

Files:
  test/functionalities/tty/TestTerminal.py

Index: test/functionalities/tty/TestTerminal.py
===================================================================
--- test/functionalities/tty/TestTerminal.py
+++ test/functionalities/tty/TestTerminal.py
@@ -22,9 +22,9 @@
     # privilege so it can't open the socket to talk back to the test case
     @unittest2.skipUnless(os.geteuid() != 0, "test cannot be run as root")
 
-    # Do we need to disable this test if the testsuite is being run on a rmeote system?
+    # Do we need to disable this test if the testsuite is being run on a remote system?
     # This env var is only defined when the shell is running in a local mac terminal window
-    # @unittest2.skipUnless(os.environ.has_key('TERM_PROGRAM'), "test must be run on local system")
+    @unittest2.skipUnless(os.environ.has_key('TERM_PROGRAM'), "test must be run on local system")
 
     def test_launch_in_terminal (self):
         exe = "/bin/ls"

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7930.20825.patch
Type: text/x-patch
Size: 916 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150227/103ffdfe/attachment.bin>