[Lldb-commits] [PATCH] Reduce the number of components initialized by lldb-server to reduce static binary size.

[Robert Flack]

Hey, I tried to move everything over and then moved plugins back to guarded by #if defined(__APPLE__) on a case by case basis as I found out why they would not compile and included the reasons in responses to your original comments. Please take a look, thanks.


REPOSITORY
  rL LLVM

================
Comment at: source/lldb.cpp:240
@@ -220,2 +239,3 @@
 #endif
-
+#if defined (__APPLE__)
+        ProcessKDP::Initialize();
----------------
clayborg wrote:
> Remove the #if defined (__APPLE__) and always compile these for cross debugging.
ProcessMachCore and ProcessKDP depend on DynamicLoaderDarwinKernel which depends on PlatformDarwinKernel which includes Mac-specific sources (Host/macosx/cfcpp/CFCBundle.h)

================
Comment at: source/lldb.cpp:292
@@ -285,2 +291,3 @@
+
 #if defined (__APPLE__)
     DynamicLoaderMacOSXDYLD::Terminate();
----------------
clayborg wrote:
> Remove the #if defined (__APPLE__) and always compile these for cross debugging.
ObjectFileMacho: includes RegisterContextDarwin_x86_64 and extends RegisterContextDarwin_x86_64 which includes <mach/*>

DynamicLoaderDarwinKernel, as mentioned earlier includes mac only resources.

SymbolVendorMacOSX requires libxml2, while I was able to update the Linux build to find this I had some trouble getting cmake to find it in Windows. If we want to add this I think (I may be mistaken) we need to include the path to GnuWin32 (which includes libxml2) as a cmake config parameter so that it can locate libxml2.

http://reviews.llvm.org/D7880

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/