[Lldb-commits] [lldb] r230671 - Can't set watchpoints on launching threads on Linux LLGS.

Chaoren Lin chaorenl at google.com
Thu Feb 26 11:48:16 PST 2015


Author: chaoren
Date: Thu Feb 26 13:48:15 2015
New Revision: 230671

URL: http://llvm.org/viewvc/llvm-project?rev=230671&view=rev
Log:
Can't set watchpoints on launching threads on Linux LLGS.

Summary:
They'll be set anyway when the thread starts running, so the launching threads
should just ignore the set request.

Reviewers: ovyalov

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D7914

Modified:
    lldb/trunk/source/Plugins/Process/Linux/NativeThreadLinux.cpp

Modified: lldb/trunk/source/Plugins/Process/Linux/NativeThreadLinux.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/NativeThreadLinux.cpp?rev=230671&r1=230670&r2=230671&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/NativeThreadLinux.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Linux/NativeThreadLinux.cpp Thu Feb 26 13:48:15 2015
@@ -218,6 +218,8 @@ NativeThreadLinux::SetWatchpoint (lldb::
 {
     if (!hardware)
         return Error ("not implemented");
+    if (m_state == eStateLaunching)
+        return Error ();
     Error error = RemoveWatchpoint(addr);
     if (error.Fail()) return error;
     NativeRegisterContextSP reg_ctx = GetRegisterContext ();





More information about the lldb-commits mailing list