[Lldb-commits] [PATCH] Fix handling of backslashes in Args parsing

[Greg Clayton]

Remove the function:

  void
  Args::SetCommandString (const char *command, size_t len)

now that we have a  llvm::StringRef based one.


================
Comment at: include/lldb/Interpreter/Args.h:124-126
@@ -122,5 +123,5 @@
 
     void
     SetCommandString (const char *command, size_t len);
 
     bool
----------------
You can remove this function now that we have a llvm::StringRef version.

================
Comment at: source/Interpreter/Args.cpp:147-151
@@ -148,10 +146,7 @@
 
 void
 Args::SetCommandString (const char *command, size_t len)
 {
-    // Use std::string to make sure we get a NULL terminated string we can use
-    // as "command" could point to a string within a large string....
-    std::string null_terminated_command(command, len);
-    SetCommandString(null_terminated_command.c_str());
+    SetCommandString(llvm::StringRef(command, len));
 }
 
----------------
Remove this function now that we have a llvm::StringRef version.

http://reviews.llvm.org/D7855

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/