[Lldb-commits] [PATCH] Move the shell expansion code to Host/common
Zachary Turner
zturner at google.com
Wed Feb 25 10:29:30 PST 2015
Well, I agree in principle that the API is meant to support process
launching. But if its utility can be trivially extended to support other
use cases, then why not?
FWIW, when I decided to do this, it was only to enable the functionality
for other platforms (i.e. moving from specific dirs to common), because
only Windows is going to have a different codepath here so it didn't make
sense to increase the code debt for everyone just because of Windows. Then
changing of the signature was just something I noticed on the side. I can
change it back if people feel strongly, but at the same time, I really like
making code as general as possible, as long as the generality doesn't
hinder the readability or usability for the primary use case (which in this
case I don't think it does)
http://reviews.llvm.org/D7805
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list