[Lldb-commits] [PATCH] Move the shell expansion code to Host/common

[Enrico Granata]

-    
-    void
-    SetShellExpandArguments (bool glob);
-    
+
+    void SetShellExpandArguments(bool expand);
+

Yes, totally

-    static Error
-    ShellExpandArguments (ProcessLaunchInfo &launch_info);
-    
+    static Error ShellExpandArguments(llvm::StringRef input, llvm::StringRef working_dir, std::vector<std::string> &expanded);
+

Why? I see no benefit to doing this. This API is clearly meant to support process launching. This change seems a net loss to me.

The actual moving of the argdumper logic to Host/common is fine (as long as the mechanism for individual platforms to opt out is trivial, that is) - the change in signature from ProcessLaunchInfo to bunch-of-stuff not so much

-    if (launch_info.GetFlags().Test(eLaunchFlagShellExpandArguments))

This should be fine do to do, yes

> On Feb 24, 2015, at 7:31 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Anyone have thoughts on this?  If there's no suggestions I'd like to commit, but I'll give another day or two for comments.
> 
> 
> http://reviews.llvm.org/D7805
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150225/36b91ba4/attachment.html>