[Lldb-commits] [PATCH] Increase default packet timeout for android to 20s

[Tamas Berghammer]

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:44
@@ +43,3 @@
+#ifdef __ANDROID__
+    static uint32_t g_default_packet_timeout = 20; // seconds
+#else
----------------
ovyalov wrote:
> ovyalov wrote:
> > Could you add secs suffix to this variable?
> If there is no existing use cases to modify this variable I'd rather declare it as constexpr within anonymous namespace.
> 
> 
Renamed to g_default_packet_timeout_sec

================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:44
@@ +43,3 @@
+#ifdef __ANDROID__
+    static uint32_t g_default_packet_timeout = 20; // seconds
+#else
----------------
tberghammer wrote:
> ovyalov wrote:
> > ovyalov wrote:
> > > Could you add secs suffix to this variable?
> > If there is no existing use cases to modify this variable I'd rather declare it as constexpr within anonymous namespace.
> > 
> > 
> Renamed to g_default_packet_timeout_sec
As far as I know constexpr is not supported by MSVC but I made these variables const.

http://reviews.llvm.org/D7853

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/