[Lldb-commits] [PATCH] Increase default packet timeout for android to 20s

Tamas Berghammer tberghammer at google.com
Tue Feb 24 02:34:22 PST 2015


Hi ovyalov, vharron,

Increase default packet timeout for android to 20s

It is required because of the unreliable speed of the adb communication and the android emulator.

http://reviews.llvm.org/D7853

Files:
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

Index: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
===================================================================
--- source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
+++ source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
@@ -40,6 +40,12 @@
 using namespace lldb;
 using namespace lldb_private;
 
+#ifdef __ANDROID__
+    static uint32_t g_default_packet_timeout = 20; // seconds
+#else
+    static uint32_t g_default_packet_timeout = 0; // not specified
+#endif
+
 //----------------------------------------------------------------------
 // GDBRemoteCommunicationServerCommon constructor
 //----------------------------------------------------------------------
@@ -236,6 +242,9 @@
     }
 #endif  // #if defined(__APPLE__)
 
+    if (g_default_packet_timeout > 0)
+        response.Printf ("default_packet_timeout:%u;", g_default_packet_timeout);
+
     return SendPacketNoLock (response.GetData(), response.GetSize());
 }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7853.20584.patch
Type: text/x-patch
Size: 1008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150224/b6b131ec/attachment.bin>


More information about the lldb-commits mailing list