[Lldb-commits] [PATCH] Fix TestStubSetSID after unification in to a single lldb-server binary.

Siva Chandra sivachandra at google.com
Fri Feb 20 14:51:54 PST 2015


Address ovyalov's comment.


http://reviews.llvm.org/D7801

Files:
  test/tools/lldb-gdbserver/commandline/TestStubSetSID.py

Index: test/tools/lldb-gdbserver/commandline/TestStubSetSID.py
===================================================================
--- test/tools/lldb-gdbserver/commandline/TestStubSetSID.py
+++ test/tools/lldb-gdbserver/commandline/TestStubSetSID.py
@@ -13,6 +13,11 @@
 import time
 from lldbtest import *
 
+
+def get_common_stub_args():
+    return [] if 'darwin' in sys.platform else ['g']
+
+
 class TestStubSetSIDTestCase(gdbremote_testcase.GdbRemoteTestCaseBase):
     def get_stub_sid(self, extra_stub_args=None):
         # Launch debugserver
@@ -34,11 +39,11 @@
         self.assertEquals(stub_sid, os.getsid(0))
 
     def sid_is_different_with_setsid(self):
-        stub_sid = self.get_stub_sid(" --setsid")
+        stub_sid = self.get_stub_sid(" %s --setsid" % ' '.join(get_common_stub_args()))
         self.assertNotEquals(stub_sid, os.getsid(0))
 
     def sid_is_different_with_S(self):
-        stub_sid = self.get_stub_sid(" -S")
+        stub_sid = self.get_stub_sid(" %s -S" % ' '.join(get_common_stub_args()))
         self.assertNotEquals(stub_sid, os.getsid(0))
 
     @debugserver_test

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7801.20439.patch
Type: text/x-patch
Size: 1113 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150220/38682d66/attachment.bin>


More information about the lldb-commits mailing list