[Lldb-commits] [PATCH] Set error status when failed to catch stop after launch

Tamas Berghammer tberghammer at google.com
Fri Feb 20 03:53:22 PST 2015


Hi clayborg, ovyalov,

Set error status when failed to catch stop after launch

Process::Launch try to catch a stop signal after launching a process. If it is unsuccessful it destroy the process but previously still reported that the process launched successfully. This behavior caused a deadlock. With this change the process launch error reported correctly.

http://reviews.llvm.org/D7784

Files:
  source/Target/Process.cpp

Index: source/Target/Process.cpp
===================================================================
--- source/Target/Process.cpp
+++ source/Target/Process.cpp
@@ -3101,6 +3101,7 @@
                     {
                         // We were able to launch the process, but we failed to
                         // catch the initial stop.
+                        error.SetErrorString ("failed to catch stop after launch");
                         SetExitStatus (0, "failed to catch stop after launch");
                         Destroy();
                     }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7784.20385.patch
Type: text/x-patch
Size: 564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150220/fabe6701/attachment.bin>


More information about the lldb-commits mailing list