[Lldb-commits] [PATCH] Introduce FileSystem::CalculateMD5AsString that supports any platform and make existing FileSystem::CalculateMD5 to use it.
ovyalov at google.com
Thu Feb 19 17:06:59 PST 2015
Comment at: source/Host/common/FileSystem.cpp:62
@@ +61,3 @@
+FileSystem::CalculateMD5AsString(const FileSpec &file_spec, std::string& digest_str)
> I'm not sure how important it is for you to have the result in an std::string. For example, are you going to pass it in to another API that accepts an std::string? Or are you just going to print it or log it? As a result, you might consider changing the second argument to an llvm::SmallString<32> & which will save a heap allocation and a string copy. But this is minor, so up to you. Otherwise LGTM
Let me leave it as std::string since I'd prefer to keep this function signature more generic.
More information about the lldb-commits