[Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.

Zachary Turner zturner at google.com
Thu Feb 19 14:28:55 PST 2015


Enrico, will your planned changes address the original issue?  Namely, that
if a process is launched through the process plugin with the
eLaunchFlagGlobArguments flag set, after your changes will the arguments
correctly go through the globber first?

On Thu Feb 19 2015 at 2:10:00 PM Enrico Granata <egranata at apple.com> wrote:

> Please do not commit this
>
> Per previous email, this is not Target functionality and should not be in
> Target at all
> The current code is at least in the conceptually reasonable place
> (Platform)
>
> I see no benefit to making things worse
>
> On Feb 19, 2015, at 1:03 PM, Siva Chandra <sivachandra at google.com> wrote:
>
> Per the current design, the globbing feature will not work for remote
> debugging. Enrico has mentioned that he is working on the generalizing this
> feature. Until then, I do not see any harm in putting this in. Will commit
> shortly.
>
>
> http://reviews.llvm.org/D7743
>
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
> Thanks,
> *- Enrico*
> 📩 egranata@.com ☎️ 27683
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150219/447c552f/attachment.html>


More information about the lldb-commits mailing list