[Lldb-commits] [PATCH] Introduce FileSystem::CalculateMD5AsString that supports any platform and make existing FileSystem::CalculateMD5 to use it.

Zachary Turner zturner at google.com
Thu Feb 19 14:23:30 PST 2015

Thanks for working on this.  It always bothered me that this was platform-specific.

Comment at: include/lldb/Host/FileSystem.h:39-40
@@ -38,3 +38,4 @@
     static bool CalculateMD5(const FileSpec &file_spec, uint64_t &low, uint64_t &high);
+    static bool CalculateMD5AsString(const FileSpec &file_spec, std::string& digest_str);
I think it might be more useful to put these functions in LLVM.  I'm thinking we should delete both of these and add 

    void llvm::sys::fs::md5_contents(const Twine &Path, llvm::MD5Result &Result);



More information about the lldb-commits mailing list