[Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.

[Enrico Granata]

Disclaimer: any mention of “glowing” instead of “globbing” is autocorrect

Over the next couple days, I want to spend some time generalizing this whole globbing thing

Right now, it only works for local debugging, which is ugly.
The theory is that Platforms should have a way to specify how they want globbing done.
POSIXy platforms would call argdumper or an equivalent incantation. Windows could perform a rain dance, and maybe some other platform has no notion of globbing in the first place, so it would just say “sorry no can do”

If you think about it, when launching a process on a remote machine, you want the globbing to happen there, not on your host
The fact that the code currently does that is just an artifact of me juggling several different tasks at once, and not having had time to wrap this up
It should not be turned from a temporary sad state of affairs into a conscious design choice

> On Feb 18, 2015, at 5:38 PM, Siva Chandra <sivachandra at google.com> wrote:
> 
> Hi clayborg, granata.enrico, zturner, ovyalov,
> 
> This way, the process will recieve globbed arguments even if it was
> launched via the process plugin.
> 
> http://reviews.llvm.org/D7743
> 
> Files:
>  source/Target/Platform.cpp
>  source/Target/Target.cpp
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D7743.20243.patch>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150219/b2bd3632/attachment.html>