[Lldb-commits] [PATCH] Factor out common URL handling code in PlatformRemoteGDBServer

[Vince Harron]

some minor suggestions.  Greg is OOTO this week.  Please land uncontroversial patches and we'll fix up when he gets back.


================
Comment at: source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp:40
@@ -39,1 +39,3 @@
 
+static std::string MakeConnectUrl (const std::string &platform_hostname, uint16_t port)
+{
----------------
s/MakeConnectUrl/MakeGdbServerUrl/g

================
Comment at: source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp:595
@@ -591,3 +594,3 @@
                         if (error.Fail())
-                            error = process_sp->ConnectRemote (NULL, connect_url);
+                            error = process_sp->ConnectRemote (NULL, connect_url.c_str());
                         if (error.Success())
----------------
nit: s/NULL/nullptr

http://reviews.llvm.org/D7751

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/