[Lldb-commits] [PATCH] Reduce number of threads in lldb-mi.

Ilia K ki.stfu at gmail.com
Thu Feb 19 08:02:29 PST 2015

In http://reviews.llvm.org/D7746#126524, @abidh wrote:

> > - use CMICmnStreamStdin::ReadLine
> I dont think that is correct. CMICmnStreamStdin::ReadLine delegate to classes for Windows and Linux. Windows class especailly touches some members which are set in InputAvailable which we are not using anymore.
>  When we have removed the input monitoring thread, most of the function in this class are redundant. Longer term, I think this class will go.

We can reduce its logic and remove CMICmnStreamStdinWindows and CMICmnStreamStdinLinux. I just want to keep the stdin operations in separate file, as it were done for stdout/stderr. It looks good for me.



More information about the lldb-commits mailing list