[Lldb-commits] [PATCH] Reduce number of threads in lldb-mi.

Hafiz Abid Qadeer abidh.haq at gmail.com
Thu Feb 19 07:43:00 PST 2015

In http://reviews.llvm.org/D7746#126486, @ki.stfu wrote:

> Let's summarize:
> - remove unnecessary code in this patch (don't do it in different revision)

Ok. I have done more cleanup. But a lot of things are connected. I prefer to go in relatively small patches. In that cases, it is easier to figure out which commit caused a breakage.

> - keep CMICmnStreamStdin/CMICmnStreamStdout/CMICmnStreamStderr class

I dont intend to remove them in this patch anyway. But longer term, we will see.

> - use CMICmnStreamStdin::ReadLine

I dont think that is correct. CMICmnStreamStdin::ReadLine delegate to classes for Windows and Linux. Windows class especailly touches some members which are set in InputAvailable which we are not using anymore.

When we have removed the input monitoring thread, most of the function in this class are redundant. Longer term, I think this class will go.

> - use ExecuteCommand instead of InjectCommand in LocalDebugSessionStartupInjectCommands (and rename it to LocalDebugSessionStartupExecuteCommands)

I have done that and removed Queue and InjectMICommands functions.

I will post updated patch shortly.



More information about the lldb-commits mailing list