[Lldb-commits] [PATCH] Reduce number of threads in lldb-mi.

Ilia K ki.stfu at gmail.com
Thu Feb 19 07:02:09 PST 2015


================
Comment at: tools/lldb-mi/MIDriver.h:184
@@ +183,2 @@
+
+bool ReadLine(CMIUtilString &cmd);
----------------
abidh wrote:
> ki.stfu wrote:
> > I think you should use existing code from MICmnStreamStdin.
> A lot of those classes will be unnecessary after this revision and I plan to remove them. So only this Readline will be kept.
I think we should move this functionality to CMICmnStreamStdin class and keep it (if you want to delete entire class).

http://reviews.llvm.org/D7746

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list