[Lldb-commits] [PATCH] Add -stack-info-frame command (MI)

Ed Maste emaste at freebsd.org
Thu Feb 19 06:21:37 PST 2015

Comment at: tools/lldb-mi/MICmdCmdStack.h:80
@@ +79,3 @@
+// Gotchas: None.
+// Authors: Ilia Kirianovskii 23/01/2015.
+// Changes: None.
abidh wrote:
> I think we should not continue this practice of adding the name of the authors. 
The `Gotchas` and `Changes` header entries are also atypical for LLDB.

Looking through tools/lldb-mi I see exactly one `Changes` entry that is not 'None`:
MICmnStreamStdin.h:38:// Changes: Factored out OS specific handling of reading stdin  - IOR 16/06/2014.
SVN is very good at tracking changes to these files; there's no need to try to do it manually as well.

I also see only four `Gotchas` that are not `None`, two of which are the same. I'd suggest we just avoid these in newly added code.



More information about the lldb-commits mailing list