[Lldb-commits] [PATCH] Skip lldb-mi tests on FreeBSD for now

Ilia K ki.stfu at gmail.com
Wed Feb 18 09:46:59 PST 2015


In http://reviews.llvm.org/D7727#125597, @emaste wrote:

> In http://reviews.llvm.org/D7727#125574, @ki.stfu wrote:
>
> > I think it will be easier to control if you skip each lldb-mi test using @ skipIfFreeBSD annotation.
>
>
> I tried adding @skipIfFreeBSD on each one as it failed, but the failures are inconsistent and different ones come up on subsequent runs. It seems like it will just be a lot of churn for no real benefit to go that way.
>
> This approach makes it easy to run the lldb-mi tests with +m when we think it's worthwhile without having to back out all of the individual annotations each time.


If it works unstable on FreeBSD you should skip it and later we can re-enable test on FreeBSD when it will be fixed. I don't see a reason to modify dotest.py file.

FYI: @zturner used the same approach in r226614 <http://reviews.llvm.org/rL226614> when he was solving pexpect issue.


http://reviews.llvm.org/D7727

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list