[Lldb-commits] [PATCH] Create x86 specific NativeRegisterContextLinux

[Chaoren Lin]

I also tried to separate i386 from x86_64, but it seemed a bit unnecessary
since the only real difference is the register sets.

The m_gpr_x86_64 does bother me a bit too, but I imagine
k_num_gpr_registers_x86_64

> k_num_gpr_registers_i386 would always be true, and we should probably

> =====================================================================


always use GetRegisterInfoInterface().GetGPRSize() instead of sizeof.

How does this look instead?

union {

uint64_t m_gpr_i386[k_num_gpr_registers_i386];
uint64_t m_gpr_x86_64[k_num_gpr_registers_x86_64];

} m_gpr;

In any case, let's get some more opinions on this first.


http://reviews.llvm.org/D7667

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/