[Lldb-commits] [PATCH] Enable process launching on android from lldb-gdbserver

Tamas Berghammer tberghammer at google.com
Mon Feb 16 02:27:04 PST 2015


================
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:33
@@ -31,3 +32,3 @@
     {
-        PluginManager::RegisterPlugin (PlatformAndroid::GetPluginNameStatic(),
-                                       PlatformAndroid::GetPluginDescriptionStatic(),
+#if defined(__ANDROID__)
+        PlatformSP default_platform_sp (new PlatformAndroid(true));
----------------
ovyalov wrote:
> Do we still need conditional compilation here?
Yes we do because each Platform*::Initialize() will be called on startup but only one of them have to register itself as a host platform.

http://reviews.llvm.org/D7613

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list