[Lldb-commits] [PATCH] Fix -stack-list-locals and -stack-list-arguments (MI)

Greg Clayton clayborg at gmail.com
Fri Feb 6 09:41:31 PST 2015


lgtm

> On Feb 6, 2015, at 5:42 AM, Ilia K <ki.stfu at gmail.com> wrote:
> 
> In http://reviews.llvm.org/D7462#119709, @ki.stfu wrote:
> 
>> In http://reviews.llvm.org/D7462#119705, @abidh wrote:
>> 
>>> Looks good to me. Although you can also handle --no-values, --all-values and --simple-values. I committed one patch yesterday that was using those for -var-list-children. I think eclipse uses those options instead of using --print-value.  
>>> Please note that I am working on a patch that touches the same area. It will be good if you can apply it quickly so that I can rebase my work to the latest.
>> 
>> 
>> I'll try to do it now.
> 
> 
> I have done it. I gonna commit this patch today if there are no objections
> 
> 
> http://reviews.llvm.org/D7462
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the lldb-commits mailing list