[Lldb-commits] [PATCH] Extract attach core logic from SBTarget::Attach* methods into unified SBTarget::AttachToProcess and make it work with platform for remote attach purposes.

Oleksiy Vyalov ovyalov at google.com
Fri Feb 6 09:30:33 PST 2015


Hi vharron, clayborg,

SBTarget::Attach, SBTarget::AttachToProcessWithID and SBTarget::AttachToProcessWithName use the same core logic - extracted it into new static method SBTarget::AttachToProcess.
Made SBTarget::AttachToProcess to support remote attach if a platform is available and can debug a process - this makes TestHelloWorld to pass in case of remote platform on Linux (test is passing when test suite and platform are running on the same machine, fully distributed test run requires further investigation).

http://reviews.llvm.org/D7471

Files:
  include/lldb/API/SBTarget.h
  source/API/SBTarget.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7471.19490.patch
Type: text/x-patch
Size: 16580 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150206/7b5ac4c6/attachment.bin>


More information about the lldb-commits mailing list