[Lldb-commits] [PATCH] Fix ConvenienceVariablesCase.test_with_dsym_and_run_command test after r227285

Ilia K ki.stfu at gmail.com
Fri Feb 6 05:32:16 PST 2015


Hi zturner, clayborg, jingham,

This fixes a test after r227285: SBThread::GetDescription should use the Thread format instead of making up

log:
```
======================================================================
FAIL: test_with_dsym_and_run_command (TestConvenienceVariables.ConvenienceVariablesCase)
Test convenience variables lldb.debugger, lldb.target, lldb.process, lldb.thread, and lldb.frame.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/testuser/build/workspace/LLDB_master_release_OSX/llvm_master/tools/lldb/test/lldbtest.py", line 456, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/testuser/build/workspace/LLDB_master_release_OSX/llvm_master/tools/lldb/test/lldbtest.py", line 612, in wrapper
    func(*args, **kwargs)
  File "/Users/testuser/build/workspace/LLDB_master_release_OSX/llvm_master/tools/lldb/test/functionalities/embedded_interpreter/TestConvenienceVariables.py", line 18, in test_with_dsym_and_run_command
    self.convenience_variables()
  File "/Users/testuser/build/workspace/LLDB_master_release_OSX/llvm_master/tools/lldb/test/functionalities/embedded_interpreter/TestConvenienceVariables.py", line 83, in convenience_variables
    patterns = ['SBThread: tid = 0x[0-9a-f]+'])
  File "/Users/testuser/build/workspace/LLDB_master_release_OSX/llvm_master/tools/lldb/test/lldbtest.py", line 2091, in expect
    msg if msg else EXP_MSG(str, exe))
AssertionError: False is not True : 'print lldb.thread
thread #1: tid = 0x80d885, 0x0000000100000f4d a.out`main(argc=1, argv=0x00007fff5fbff078) + 29 at main.c:4, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
' matches expected result
Config=x86_64-clang
```

http://reviews.llvm.org/D7464

Files:
  test/functionalities/embedded_interpreter/TestConvenienceVariables.py

Index: test/functionalities/embedded_interpreter/TestConvenienceVariables.py
===================================================================
--- test/functionalities/embedded_interpreter/TestConvenienceVariables.py
+++ test/functionalities/embedded_interpreter/TestConvenienceVariables.py
@@ -80,12 +80,12 @@
         child.sendline('print lldb.thread')
         child.expect_exact(python_prompt)
         self.expect(child.before, exe=False,
-            patterns = ['SBThread: tid = 0x[0-9a-f]+'])
+            patterns = ['thread #1: tid = 0x[0-9a-f]+, 0x[0-9a-f]+ a\.out`main\(argc=1, argv=0x[0-9a-f]+\) \+ \d+ at main\.c:%d, queue = \'.+\', stop reason = breakpoint 1\.1' % self.line])
 
         child.sendline('print lldb.frame')
         child.expect_exact(python_prompt)
         self.expect(child.before, exe=False,
-            substrs = ['frame #0', 'main.c:%d' % self.line])
+            patterns = ['frame #0: 0x[0-9a-f]+ a\.out`main\(argc=1, argv=0x[0-9a-f]+\) \+ \d+ at main\.c:%d' % self.line])
 
 
 if __name__ == '__main__':

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7464.19477.patch
Type: text/x-patch
Size: 1048 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150206/4f4c60ae/attachment.bin>


More information about the lldb-commits mailing list