[Lldb-commits] [PATCH] Fix warning about the use of mktemp and make platform agnostic by adding and using PipeBase::CreateWithUniqueName.
Adrian McCarthy
amccarth at google.com
Thu Feb 5 15:03:15 PST 2015
REPOSITORY
rL LLVM
================
Comment at: source/Host/windows/PipeWindows.cpp:105
@@ +104,3 @@
+ }
+ Error error = CreateNew(pipe_name, child_process_inherit);
+ } while (error.GetError() == ERROR_ALREADY_EXISTS);
----------------
This instance of `error` hides the one at function scope, so if creating the pipe fails for a reason other then ERROR_ALREADY_EXISTS, this function will return success.
I'll fix this as I switch it to use a GUID on Windows
http://reviews.llvm.org/D7348
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list