[Lldb-commits] [PATCH] Fix warning about the use of mktemp and make platform agnostic by adding and using PipeBase::CreateWithUniqueName.

Oleksiy Vyalov ovyalov at google.com
Wed Feb 4 15:27:26 PST 2015


Minor comment.


REPOSITORY
  rL LLVM

================
Comment at: source/Host/posix/PipePosix.cpp:216
@@ +215,3 @@
+    if (error.Success()) {
+        name.clear();
+        name = named_pipe_path;
----------------
It seems not needed here or as another option - call clear() unconditionally at the beginning of the method.

http://reviews.llvm.org/D7348

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list