[Lldb-commits] [PATCH] Add/update tests for lldb-mi

Ilia K ki.stfu at gmail.com
Wed Feb 4 09:26:35 PST 2015

In http://reviews.llvm.org/D7410#118414, @abidh wrote:

> Some observations:
> 1. I think you should have posted the pieces that dont depend on other patches. In this way, they can be reviewed and committed without waiting on others.

It doesn't depend on other patches. I meant that some tests are disabled, but we can enable them when these patches will be submitted.

> 2. The start and end address of 0 is still there in data disassemble command. Probably we can use a function address as start. Then end address can be start + 20 or something. If $pc is supported then that can be used too. GDB does a similar thing.

I'll fix it.

> 3. I don't like interpreter-exec much. I think it should only be used if you can not do stuff using other MI commands.

I'll fix it where it's possible




More information about the lldb-commits mailing list