[Lldb-commits] [PATCH] Fix break-insert command on Windows.

Zachary Turner zturner at google.com
Wed Feb 4 08:29:20 PST 2015

I mean that the string already passes through that function, so I'm
wondering why it doesn't already work
On Wed, Feb 4, 2015 at 8:28 AM Zachary Turner <zturner at google.com> wrote:

> I see. I don't have code in front of me, but can you check
> Args::SetCommandString? I thought it had code to convert \\ into \
> On Wed, Feb 4, 2015 at 8:20 AM Hafiz Abid Qadeer <abidh.haq at gmail.com>
> wrote:
>> zturner,
>> Command line case was just to show the problem. Real issue is that
>> eclipse sends out path of the file with 2 \\ in it which fails the
>> breakpoint lookup. So we have the following options.
>> 1. Change the path in lldb-mi before it reaches lldb proper. This is what
>> I tried in initial patch.
>> 2. Fix it in the FileSpec::Normalize so that it will be fixed in both
>> command line and lldb-mi.
>> 3. Fix the FileSpec:Equals to be more intelligent and does not do simple
>> string matches when it is comparing the directories. Take care of single or
>> double slashes as directory separators. But it looks to be redundant work
>> as we call Normalize on the paths before which should take care of such
>> cases.
>> http://reviews.llvm.org/D7379
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150204/509e2c37/attachment.html>

More information about the lldb-commits mailing list