[Lldb-commits] [PATCH] Remove autogenerated makefiles after running tests

[Zachary Turner]

The problem is you have to update gitignore every time you add a new test,
and to make matters worse, sometimes there is already a Makefile there but
the test suite generates a temporary one anyway, overwriting the in-tree
one.

I think a real fix for this is going to involve generating all temporary
files out of tree, or at least into one top level folder, and gitignoring
that whole folder. Each test could rm -rf the whole folder on startup, as
it could just be a scratch area for tests
On Wed, Feb 4, 2015 at 7:52 AM Vince Harron <vharron at google.com> wrote:

> The tests do clean up after themselves, unless they're interrupted.  This
> is to prevent temporary files that can't be moved out of tree from showing
> up in git status.
> On Feb 4, 2015 7:49 AM, "Zachary Turner" <zturner at google.com> wrote:
>
>> +1 for not touching gitignore. Seems like a bandaid for the real problem.
>> Tests should be smart enough to clean up after themselves.
>>
>> I thought there were cases where a Makefile was checked into tree. This
>> would also delete those right?
>> On Wed, Feb 4, 2015 at 7:22 AM Pavel Labath <labath at google.com> wrote:
>>
>>> I'm particularly fond of that idea. Even if I put full paths to all 10
>>> makefiles to .gitignore now (and I need to put full paths, as we don't want
>>> to ignore all makefiles), the list will get quickly out of sync as test
>>> cases are added/removed.
>>>
>>> Besides, if this patch goes in in this form, adding these makefiles back
>>> will be pretty difficult as they will get deleted after every testsuite run.
>>>
>>>
>>> http://reviews.llvm.org/D7407
>>>
>>> EMAIL PREFERENCES
>>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>>
>>>
>>>
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150204/dace35b1/attachment.html>