[Lldb-commits] [PATCH] Have llgs tests output their traces into session dir

[Zachary Turner]

Can you explain this a bit? I thought we were going to output them to the
lldb-test-traces folder, or whatever location was specified via -s to
dotest. I have a very strong dislike for introducing environment variable
dependencies into the test suite. And this seems to still ignore -s.
On Tue, Feb 3, 2015 at 8:18 AM Pavel Labath <labath at google.com> wrote:

> Hi vharron, zturner,
>
> This reduces the bloat in the source tree and makes the tests more
> consistent.
>
> http://reviews.llvm.org/D7373
>
> Files:
>   test/tools/lldb-gdbserver/gdbremote_testcase.py
>
> Index: test/tools/lldb-gdbserver/gdbremote_testcase.py
> ===================================================================
> --- test/tools/lldb-gdbserver/gdbremote_testcase.py
> +++ test/tools/lldb-gdbserver/gdbremote_testcase.py
> @@ -137,7 +137,9 @@
>          self.debug_monitor_exe = get_lldb_gdbserver_exe()
>          if not self.debug_monitor_exe:
>              self.skipTest("lldb_gdbserver exe not found")
> -        self.debug_monitor_extra_args = " -c 'log enable -T -f
> process-{}.log lldb break process thread' -c 'log enable -T -f
> packets-{}.log gdb-remote packets'".format(self.id(), self.id(), self.id
> ())
> +        dname = os.path.join(os.environ["LLDB_TEST"],
> +                             os.environ["LLDB_SESSION_DIRNAME"])
> +        self.debug_monitor_extra_args = " -c 'log enable -T -f
> {}/process-{}.log lldb break process thread' -c 'log enable -T -f
> {}/packets-{}.log gdb-remote packets'".format(dname, self.id(), dname,
> self.id())
>          if use_named_pipe:
>              (self.named_pipe_path, self.named_pipe, self.named_pipe_fd) =
> self.create_named_pipe()
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150203/918af2df/attachment.html>