[Lldb-commits] [PATCH] Local Linux debugging via LLGS passing all Linux local debugging tests.

[Pavel Labath]

================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3600-3623
@@ +3599,26 @@
+void *
+NativeProcessLinux::CoordinatorThread (void *arg)
+{
+    Log *const log (GetLogIfAllCategoriesSet (LIBLLDB_LOG_THREAD));
+
+    NativeProcessLinux *const process = static_cast<NativeProcessLinux*> (arg);
+    assert (process && "null process passed to CoordinatorThread");
+    if (!process)
+    {
+        if (log)
+            log->Printf ("NativeProcessLinux::%s null process, exiting ThreadStateCoordinator processing loop", __FUNCTION__);
+        return nullptr;
+    }
+
+    // Run the thread state coordinator loop until it is done.  This call uses
+    // efficient waiting for an event to be ready.
+    while (process->m_coordinator_up->ProcessNextEvent () == ThreadStateCoordinator::eventLoopResultContinue)
+    {
+    }
+
+    if (log)
+        log->Printf ("NativeProcessLinux::%s pid %" PRIu64 " exiting ThreadStateCoordinator processing loop due to coordinator indicating completion", __FUNCTION__, process->GetID ());
+
+    return nullptr;
+}
+
----------------
tberghammer wrote:
> What is the return value of this function? Can we remove it as it is always nullptr and can't be overridden as it is a static method?
I think this function signature is required by ThreadLauncher::LaunchThread().

http://reviews.llvm.org/D7238

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/