[Lldb-commits] [PATCH] Fix SBTarget::Launch's stop_at_entry which is ignored

[Zachary Turner]

Yea I will commit.  At some point (probably soon if you plan to continue
submitting patches) you should attempt to get commit access
<http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access>

On Mon Feb 02 2015 at 7:22:39 AM Ilia K <ki.stfu at gmail.com> wrote:

> In http://reviews.llvm.org/D7271#115504, @zturner wrote:
>
> > Not sure why this was ever a boolean in the first place instead of just
> having the user specify it through the launch_flags which are already
> passed into the function.  Maybe that's why it's ignored, since the
> argument is redunant because you can just create the launch_flags already
> to have eLaunchFlagsStopAtEntry?
>
>
> Maybe it's true. Actually I'd like remove this argument but I afraid we
> can't do it. (I mean we can't change public API because we should support
> the backward support, right?).
>
> > Either way, I guess since the argument exists, might as well use it.
>
>
> Do you mean that it's accepted? Can you commit it if it's so?
>
>
> REPOSITORY
>   rL LLVM
>
> http://reviews.llvm.org/D7271
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150202/29a32f96/attachment.html>